commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gary Gregory (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (VFS-442) HDFS FileSystem Provider
Date Wed, 07 Nov 2012 17:43:11 GMT

    [ https://issues.apache.org/jira/browse/VFS-442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13492536#comment-13492536
] 

Gary Gregory commented on VFS-442:
----------------------------------

Hello Dave,

I've attached version 3 of the patch that:

- IMPORTANT: adds HDFS as a provider in providers.xml.
- adds missing @Overrides annotations, 
- makes some ivars final, 
- makes some vars private,
- Edited the Javadoc on the test to say Linux is required. As my previous comment shows, Cygwin
on Windows does not work.

I cannot run most of the VFS tests in Eclipse due to the way the VFS test framework was coded
a long time ago. That's unfortunate, but that's what we have today. I often resort to debugging
VFS from Eclipse by connecting to the JVM started by a local Maven run.

TO-DOs:
# It is still important to provide a test that fits in this framework in addition to the current
test. The current test may then become obsolete.
# The test needs to be disabled on Windows. It might be best to do that from the POM, which
I don't know how to do off the top of my head. JUnit's Assume may be the solution of last
resort.
# The Maven build creates a "build" directory in the root of the project, that's not good
because someone may end up committing it by mistake or including it in a patch (like I almost
did). Is this an HDFS store? If so, put it in a folder where the system propoerty java.io.tmpdir
points to and remove it at the end of the test.
# Some Javadoc comments are missing for public members.
# Only make public what must be public.

Thank you for your time and contribution!
Gary

                
> HDFS FileSystem Provider
> ------------------------
>
>                 Key: VFS-442
>                 URL: https://issues.apache.org/jira/browse/VFS-442
>             Project: Commons VFS
>          Issue Type: New Feature
>    Affects Versions: 2.0
>            Reporter: Dave Marion
>            Priority: Minor
>              Labels: accumulo, hdfs
>         Attachments: vfs-422-3.diff, VFS-442-1.patch, VFS-442-2.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message