commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ate Douma (JIRA)" <>
Subject [jira] [Commented] (SCXML-177) Correct error/warning messages in SCXML reading to be up-to-date
Date Tue, 03 Dec 2013 15:31:40 GMT


Ate Douma commented on SCXML-177:

Logging as ERROR is an improvement, but shouldn't this better result in a ModelException instead
IMO such a SCXML definition cannot be regarded as valid when elements are 'dropped' silently.

>From this regard the SCXMLReader#reportIgnoredElement method is questionable itself.
Maybe we could/should introduce a 'strict' SCXMLReader flag, which when true (default) would
fail with ModelExceptions in such cases?
For backwards compatibility this 'strict' flag then could be set to false if so desired.

> Correct error/warning messages in SCXML reading to be up-to-date
> ----------------------------------------------------------------
>                 Key: SCXML-177
>                 URL:
>             Project: Commons SCXML
>          Issue Type: Bug
>            Reporter: Woonsan Ko
>            Assignee: Woonsan Ko
>            Priority: Trivial
>             Fix For: 2.0
> Some error/warning logs are outdated against the newest spec.
> For example,
> org.apache.commons.scxml2.model.ModelException: No SCXML child state with ID "null" found;
illegal initialstate for SCXML document
> 	at
> It should inform of 'initial', not 'initialstate' and check if it is not set.

This message was sent by Atlassian JIRA

View raw message