commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Niall Pemberton (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (VALIDATOR-325) IBAN validation not calculated correctly
Date Wed, 04 Dec 2013 15:04:36 GMT

    [ https://issues.apache.org/jira/browse/VALIDATOR-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13838960#comment-13838960
] 

Niall Pemberton commented on VALIDATOR-325:
-------------------------------------------

Its a good point, and it would probably be useful to throw a number exceptions to provide
more concise errors:
 - Code is null/blank
 - country not supported (i.e. formatValidator == null)
 - Invalid format for country
 - Invalid check digit

However this is a general problem for all these validation routines - they only provide valid/invalid
rather than specific errors and would require changing how the framework works.

For me, I don't have any interest in the framework part of Validator (and the bean validation
specification probabvly means that the framework is now dead) and part of the work done on
Validator 1.4 was to clearly separate out the actual validation routines from the framework
- which would be good if they could be released independently.

Another OT thing I found out last night is that the Apache BVal project has copied all these
chckdigit validation routines from here, which is nice:

http://svn.apache.org/repos/asf/bval/trunk/bval-extras/src/main/java/org/apache/bval/extras/constraints/checkdigit/

> IBAN validation not calculated correctly
> ----------------------------------------
>
>                 Key: VALIDATOR-325
>                 URL: https://issues.apache.org/jira/browse/VALIDATOR-325
>             Project: Commons Validator
>          Issue Type: Bug
>            Reporter: Wim Vleugels
>             Fix For: 1.4.0 Release
>
>         Attachments: IBANValidator.java
>
>
> When I try to validate an incorrect belgian IBAN code "BE7436302152834", than it passes
the validation without any problem although even the length of the code is invalid.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message