commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Thomas (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DBCP-317) Findbugs: Class doesn't override equals in superclass
Date Sun, 12 Jan 2014 17:50:51 GMT

    [ https://issues.apache.org/jira/browse/DBCP-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13869097#comment-13869097
] 

Mark Thomas commented on DBCP-317:
----------------------------------

I've fixed (removed) the unnecessary equals() methods in DelegatingPreparedStatement  and
DelegatingCallableStatement 

The issues in the original description are still to be resolved.

> Findbugs: Class doesn't override equals in superclass
> -----------------------------------------------------
>
>                 Key: DBCP-317
>                 URL: https://issues.apache.org/jira/browse/DBCP-317
>             Project: Commons Dbcp
>          Issue Type: Bug
>    Affects Versions: 1.4
>            Reporter: Sebb
>            Priority: Minor
>             Fix For: 2.0
>
>
> Findbugs: Class doesn't override equals in superclass - 8 instances
> "This class extends a class that defines an equals method and adds fields, but doesn't
define an equals method itself. Thus, equality on instances of this class will ignore the
identity of the subclass and the added fields. Be sure this is what is intended, and that
you don't need to override the equals method. Even if you don't need to override the equals
method, consider overriding it anyway to document the fact that the equals method for the
subclass just return the result of invoking super.equals(o). "
> Classes (superclass) are:
> cpdsadapter.ConnectionImpl doesn't override DelegatingConnection.equals
> datasources.LRUMap doesn't override SequencedHashMap.equals
> managed.ManagedConnection doesn't override DelegatingConnection.equals
> managed.PoolableManagedConnection  doesn't override DelegatingConnection.equals
> PoolableCallableStatement doesn't override DelegatingCallableStatement.equals
> PoolableConnection doesn't override DelegatingConnection.equals
> PoolablePreparedStatement doesn't override DelegatingPreparedStatement.equals
> PoolingConnection doesn't override DelegatingConnection.equals



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message