commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Osipov (JIRA)" <>
Subject [jira] [Commented] (LANG-1002) Several predefined ISO FastDateFormats in DateFormatUtils are incorrect
Date Thu, 01 May 2014 11:22:17 GMT


Michael Osipov commented on LANG-1002:

Gary, I think we can do the following here to minimize impact.

1. Create a new ticket which will address the entire problem in Commons Lang 4 cleanly, i.e.,
remove {{NO_T}} formats and make the other formats correct.
2. Lang 3 has to remain as-is -- unfortunately, but we deprecate can {{NO_T}} formats and
change the Javadocs of the others saying that the format will change in 4.0.

Introducing new constants like {{ISO_8601_...}} would require do add them for all formats
to have a uniform use. I think this is overhead.

What do you think?

> Several predefined ISO FastDateFormats in DateFormatUtils are incorrect
> -----------------------------------------------------------------------
>                 Key: LANG-1002
>                 URL:
>             Project: Commons Lang
>          Issue Type: Bug
>          Components: lang.time.*
>    Affects Versions: 3.3.2
>            Reporter: Michael Osipov
> Formats {{ISO_TIME_FORMAT}}, {{ISO_TIME_TIME_ZONE_FORMAT}} prepend a {{T}} but this is
not correct. Sole time is never prepended by defintion. {{T}} is used only when date *and*
time are given.
> The Javadocs of {{ISO_TIME_NO_T_FORMAT}}, {{ISO_TIME_NO_T_FORMAT}} are in correct too
because they say: "This pattern does not comply with the formal ISO8601 specification as the
standard requires the 'T' prefix for times."
> You might want to read [Markus Kuhn's reference|]
on that.
> A solution would be remove the first two and rename the second two by dropping the {{NO_T}}
in the name.

This message was sent by Atlassian JIRA

View raw message