[ https://issues.apache.org/jira/browse/LANG-1004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated LANG-1004:
---------------------------------
Description:
This method has several flaws:
1. Javadoc says: "The format used is ISO8601-like: H:m:s.S." but the method call supplies
"H:mm:ss.SSS"
2. ISO time never omits leading zeros, so the proper pattern must be "HH:mm:ss.SSS"
3. The method name says: "HMS" but includes the second fraction.
Since the use of fractions is optional, the method should use "HH:mm:ss" and update the Javadoc
as well.
was:
This method has several flaws:
1. Javadoc says: "The format used is ISO8601-like: H:m:s.S." but the method call supplies
"H:mm:ss.SSS"
2. ISO time never omits leading zeros, so the proper pattern must be "HH:mm:ss.SSS"
3. The method name says: "HMS" but omits the second fraction.
Since the use of fractions is optional, the method should use "HH:mm:ss" and update the Javadoc
as well.
> DurationFormatUtils#formatDurationHMS implementation does not correspond to Javadoc and
vice versa
> --------------------------------------------------------------------------------------------------
>
> Key: LANG-1004
> URL: https://issues.apache.org/jira/browse/LANG-1004
> Project: Commons Lang
> Issue Type: Bug
> Components: lang.text.*
> Affects Versions: 3.3.2
> Reporter: Michael Osipov
> Fix For: Patch Needed
>
>
> This method has several flaws:
> 1. Javadoc says: "The format used is ISO8601-like: H:m:s.S." but the method call supplies
"H:mm:ss.SSS"
> 2. ISO time never omits leading zeros, so the proper pattern must be "HH:mm:ss.SSS"
> 3. The method name says: "HMS" but includes the second fraction.
> Since the use of fractions is optional, the method should use "HH:mm:ss" and update the
Javadoc as well.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
|