commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Neidhart (JIRA)" <>
Subject [jira] [Resolved] (COLLECTIONS-523) Removing unnecessary method
Date Mon, 19 May 2014 20:49:40 GMT


Thomas Neidhart resolved COLLECTIONS-523.

       Resolution: Fixed
    Fix Version/s: 4.1

Removed method in r1596053.

It was there since the original commit, maybe by accident after changing the interface of
the ExpirationPolicy.

Anyway it was confusing as the parameter was not used and safe to remove the method.

Thanks for the report.

> Removing unnecessary method
> ---------------------------
>                 Key: COLLECTIONS-523
>                 URL:
>             Project: Commons Collections
>          Issue Type: Improvement
>          Components: Map
>    Affects Versions: 4.0
>            Reporter: Thiago Andrade
>            Priority: Minor
>             Fix For: 4.1
> I suggest remmove unnecessary method {{private V put(final K key, final V value, final
long now)}} from the class {{PassiveExpiringMap}} once the {{final long now}} parameter was
never used. I've addapted the code to work properly.
> The param was confusing the logic of this method.
> Placeholder ticket for github PR 2:

This message was sent by Atlassian JIRA

View raw message