commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CSV-117) Validate format parameters in constructor
Date Sat, 24 May 2014 14:27:01 GMT

    [ https://issues.apache.org/jira/browse/CSV-117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14008136#comment-14008136
] 

Sebb commented on CSV-117:
--------------------------

The order is not constrained initially, except that escape must be set before using Quote.NONE

Changes to parameters that have already been set are constrained in that each change is validated
against the other parameters.

This was discussed on the ML.

The purpose of this change is to find problem settings as early as possible, rather than when
the format is used.
I could see no other way of doing this other than by using a build() method.
However, IIRC that was voted down some while back.

> Validate format parameters in constructor
> -----------------------------------------
>
>                 Key: CSV-117
>                 URL: https://issues.apache.org/jira/browse/CSV-117
>             Project: Commons CSV
>          Issue Type: Improvement
>          Components: Parser
>            Reporter: Sebb
>         Attachments: CSV-117.patch
>
>
> As per ML discussion, here is a patch which moves CSVFormat parameter validation into
the constructor. Tests still work once ISE replaced by IAE in the expected exceptions.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message