commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gary Gregory (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IO-463) FileSystemUtils#freeSpace can be simplified by using new Java 6 File methods
Date Wed, 03 Dec 2014 15:26:13 GMT

    [ https://issues.apache.org/jira/browse/IO-463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14233104#comment-14233104
] 

Gary Gregory commented on IO-463:
---------------------------------

I do not think we should throw an exception. The {{freeSpace }} method sounds like a minefield
as it is because "Javadoc says it does not normalise the value". If we re-implement the method,
then we are changing the documented behavior, bleh. I don't want to explain how that is OK,
it does not feel right.

What about:
- We document {{File}} usage as the class level.
- freeSpace stays deprecated, document {{File}} methods.
- re-implementing {{freeSpaceKb}} methods using {{File}}. These methods do not have to be
deprecated because they return values in Kb instead of bytes so there is some sort of extra
value there.

Thoughts?

> FileSystemUtils#freeSpace can be simplified by using new Java 6 File methods
> ----------------------------------------------------------------------------
>
>                 Key: IO-463
>                 URL: https://issues.apache.org/jira/browse/IO-463
>             Project: Commons IO
>          Issue Type: Improvement
>            Reporter: Sebb
>
> Commons IO now requires Java 1.6, which has some useful new File methods:
> File.getFreeSpace() / getUsableSpace()
> These could be used to radically simplify (and speed up) the FileSystemUtils freeSpace
methods, as well as making it OS-independent.
> The methods should be deprecated in favour of directly calling the File methods directly.
Perhaps even deprecate the entire class?  - it only contains the freeSpace methods currently.
> Note: a lot of the tests will becorme redundant or need reworking.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message