commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Roberts (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BCEL-196) why is Instruction.setOpcode private?
Date Mon, 09 Mar 2015 15:27:39 GMT

    [ https://issues.apache.org/jira/browse/BCEL-196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14353106#comment-14353106
] 

Mark Roberts commented on BCEL-196:
-----------------------------------

I must apologize for this request.  Some time ago we used setOpcode to, for example, change
an 'aload_1' to an 'aload_2'.  Later we realized that just incrementing the index with setIndex
was good enough, BCEL took care of the details. (well done)  Unfortunately, we never undid
our change to make setOpcode public and when I diffed our tree with yours this change was
still there and I included it in my list.

Long story short - go ahead and close this issue.


> why is Instruction.setOpcode private?
> -------------------------------------
>
>                 Key: BCEL-196
>                 URL: https://issues.apache.org/jira/browse/BCEL-196
>             Project: Commons BCEL
>          Issue Type: Bug
>            Reporter: Mark Roberts
>         Attachments: instruction.diff
>
>
> Am I missing another way to modify an instruction opcode?  Deleting and recreating does
not appear to be a good alternative due to having to deal with target pointers. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message