commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Baker (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SANDBOX-493) Change (R) StringMetric.compare(CS left, CS right) to "apply" so that it is consistent with BiFunction.
Date Tue, 03 Mar 2015 12:41:05 GMT

    [ https://issues.apache.org/jira/browse/SANDBOX-493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14345020#comment-14345020
] 

Jonathan Baker commented on SANDBOX-493:
----------------------------------------

Thanks to you both.  I was thinking the same things.

1. I wanted to make sure it was OK to switch from the more meaningful "compare" to the more
abstract-able "apply."

2. Should I switch them all to BiFunction (Java 8) as part of this ticket?
Running "mvn test" against 1.8.0_31 64 bit Java (Win 7 Pro 64) worked OK.

Please confirm since I don't want to anger any torch-wielding mobs of pre-8 Java users.  :)
(Disclosure: Our shop is using Java 6, and a "mvn test" failed for me using 1.6.0_45.  :(
)

> Change (R) StringMetric.compare(CS left, CS right) to "apply" so that it is consistent
with BiFunction.
> -------------------------------------------------------------------------------------------------------
>
>                 Key: SANDBOX-493
>                 URL: https://issues.apache.org/jira/browse/SANDBOX-493
>             Project: Commons Sandbox
>          Issue Type: Improvement
>          Components: Commons Text
>            Reporter: Jonathan Baker
>            Priority: Minor
>
> Whenever commons-text supports Java 8, StringMetric<R> should extend BiFunction<CharSequence,
CharSequence, R>.  Renaming "compare" to "apply" now will make that transition smoother
later.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message