commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gary Gregory (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CSV-154) CSVFormat.withHeaderComments() doesn't print comments header comments depending on when it is called
Date Tue, 01 Sep 2015 05:34:46 GMT

    [ https://issues.apache.org/jira/browse/CSV-154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14724818#comment-14724818
] 

Gary Gregory commented on CSV-154:
----------------------------------

These tests pass:

{code:java}
    @Test
    public void testJiraCsv154_withCommentMarker() throws IOException {
        final String comment = "This is a header comment";
        CSVFormat format = CSVFormat.EXCEL.withHeader("H1", "H2").withCommentMarker('#').withHeaderComments(comment);
        StringBuilder out = new StringBuilder();
        final CSVPrinter printer = format.print(out);
        printer.print("A");
        printer.print("B");
        printer.close();
        String s = out.toString();
        Assert.assertTrue(s, s.contains(comment));
    }

    @Test
    public void testJiraCsv154_withHeaderComments() throws IOException {
        final String comment = "This is a header comment";
        CSVFormat format = CSVFormat.EXCEL.withHeader("H1", "H2").withHeaderComments(comment).withCommentMarker('#');
        StringBuilder out = new StringBuilder();
        final CSVPrinter printer = format.print(out);
        printer.print("A");
        printer.print("B");
        printer.close();
        String s = out.toString();
        Assert.assertTrue(s, s.contains(comment));
    }
{code}

Can you submit a unit test that fails with the SVN trunk code? With 1.2 would be OK as well.

> CSVFormat.withHeaderComments() doesn't print comments header comments depending on when
it is called
> ----------------------------------------------------------------------------------------------------
>
>                 Key: CSV-154
>                 URL: https://issues.apache.org/jira/browse/CSV-154
>             Project: Commons CSV
>          Issue Type: Bug
>          Components: Printer
>    Affects Versions: 1.1
>            Reporter: Raffi Khatchadourian
>            Priority: Minor
>
> When building a CSVFormat with header comments, the order in which the with* methods
are called determines if the header comments will appear (note that this does not seem to
be an issue with the header, just the header comments). For example, the following code *will
not* print a header comment:
> {code}
> Stream<String> header = getCSVHeader();
> CSVFormat format = CSVFormat.EXCEL.withHeader(header.toArray(String[]::new)).withHeaderComments("Maximum
analysis depth: " + this.getMaximumAnalysisDepth()).withCommentMarker('#');
> System.out.println(format.getHeaderComments());
> {code}
> while this code *will* print them:
> {code}
> Stream<String> header = getCSVHeader();
> CSVFormat format = CSVFormat.EXCEL.withHeader(header.toArray(String[]::new)).withCommentMarker('#').withHeaderComments("Maximum
analysis depth: " + this.getMaximumAnalysisDepth());
> System.out.println(format.getHeaderComments());
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message