commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dapeng Sun (JIRA)" <>
Subject [jira] [Updated] (CRYPTO-90) Utils loads system properties during class loading
Date Wed, 06 Jul 2016 05:57:10 GMT


Dapeng Sun updated CRYPTO-90:
    Assignee: Dapeng Sun  (was: Sebb)

> Utils loads system properties during class loading
> --------------------------------------------------
>                 Key: CRYPTO-90
>                 URL:
>             Project: Commons Crypto
>          Issue Type: Bug
>            Reporter: Sebb
>            Assignee: Dapeng Sun
>             Fix For: 1.0.0
> The Utils class reads properties from a properties file if it exists, and adds them to
the set of System properties.
> There are several problems with this:
> - there's no way of knowing exactly when the properties will be processed, because it
depends when the Utils class is first used
> - generally it's a bad idea to update System properties.
> - updates to System properties require additional privileges, so the behaviour of the
code will depend on the environment in which it is run.
> - the code catches Throwable, which is not allowed.
> If there is a use case for supporting a properties file, it should be processed at a
predictable stage in the code, should be done before command-line parameters are processed,
and should not require updating System properties.

This message was sent by Atlassian JIRA

View raw message