commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tqup3 (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (NET-609) DefaultUnixFTPFileEntryParserFactory Issue (leading spaces removal configuration)
Date Fri, 06 Jan 2017 11:15:59 GMT

     [ https://issues.apache.org/jira/browse/NET-609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Tqup3 updated NET-609:
----------------------
    Labels:   (was: easyfix)

> DefaultUnixFTPFileEntryParserFactory Issue (leading spaces removal configuration)
> ---------------------------------------------------------------------------------
>
>                 Key: NET-609
>                 URL: https://issues.apache.org/jira/browse/NET-609
>             Project: Commons Net
>          Issue Type: Bug
>          Components: FTP
>    Affects Versions: 3.4
>            Reporter: Tqup3
>
> I have an issue when calling listFiles() method on a FTP server.
> The FTPFileEntry parser fail to parse the entry by adding a non existing leading space
in the filename.
> In the FTP library, a boolean field is existing to remove the leading spaces and needs
to be set to true (in my case).
> The issue is in the file DefaultUnixFTPFileEntryParserFactory.java (L124-L128) :
> {code:java}
> if (parser == null) { // Now try for aliases
>             String ukey = key.toUpperCase(java.util.Locale.ENGLISH);
>             if (ukey.indexOf(FTPClientConfig.SYST_UNIX) >= 0)
>             { // FTPClientConfig.SYST_UNIX = "UNIX"
>                 parser = new UnixFTPEntryParser(config, false);
>             }
>             else if  (ukey.indexOf(FTPClientConfig.SYST_UNIX_TRIM_LEADING) >= 0)
>             { // FTPClientConfig.SYST_UNIX_TRIM_LEADING = "UNIX_LTRIM"
>                 parser = new UnixFTPEntryParser(config, true);
>             }
>             // ...
> }
> {code}
> I think the issue is that the else if condition is unreachable because if second condition
is true, the first condition is matching too :
> FTPClientConfig.SYST_UNIX = "UNIX"
> FTPClientConfig.SYST_UNIX_TRIM_LEADING = "UNIX_LTRIM"
> I think the issue is related to the commit on NET-566 (commit: http://svn.apache.org/viewvc?view=revision&revision=1652696)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message