commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BCEL-296) Incorrect comment in several classes.
Date Fri, 13 Oct 2017 17:33:01 GMT

    [ https://issues.apache.org/jira/browse/BCEL-296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16203906#comment-16203906
] 

ASF GitHub Bot commented on BCEL-296:
-------------------------------------

GitHub user markro49 opened a pull request:

    https://github.com/apache/commons-bcel/pull/16

    BCEL-296: correct empty constructor comments

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/markro49/commons-bcel bcel296

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-bcel/pull/16.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #16
    
----
commit d06e3fee133eef460289455a3a82f9c3ec525306
Author: Mark Roberts <markro@cs.washington.edu>
Date:   2017-10-13T17:30:02Z

    correct empty constructor comments

----


> Incorrect comment in several classes.
> -------------------------------------
>
>                 Key: BCEL-296
>                 URL: https://issues.apache.org/jira/browse/BCEL-296
>             Project: Commons BCEL
>          Issue Type: Improvement
>            Reporter: Mark Roberts
>            Priority: Trivial
>
> There are 70 odd classes in the generic directory that have empty constructors with the
following comment:
>      * Empty constructor needed for the Class.newInstance() statement in
>      * Instruction.readInstruction(). Not to be used otherwise.
> Class.newInstance() is no longer called, the empty constructors are referenced directly.
 Perhaps the comment should just read:
>  * Empty constructor needed Instruction.readInstruction(). 
>  * Not to be used otherwise.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message