commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kinow <...@git.apache.org>
Subject [GitHub] commons-lang issue #311: LANG-1373 Stopwatch based capability for nested, na...
Date Fri, 26 Jan 2018 19:41:04 GMT
Github user kinow commented on the issue:

    https://github.com/apache/commons-lang/pull/311
  
    Ack :-) haven't had time to review it as we have a short summer around here, so have added
a note to have a look at StopWatch (which I'm not familiar with) and at this variation.
    
    Said that, had a very brief peek at the code from the browser without using the IDE. The
code looks great! Only small minor things I could see were a duplicated white line (which
doesn't matter tbh) and the the formatting. If I recall correctly, [lang] uses 4 spaces instead
of 2? Though I could be wrong.
    
    Thanks for being so patient. I intend to review it as soon as I get some spare time (IOW
once the weather gets back to our normal 10-17C cloudy days with with windy rains). But happy
if anyone beats me to it.
    
    Cheers
    Bruno 


---

Mime
View raw message