commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (LANG-1373) Stopwatch based capability for nested, named, timings in a call stack
Date Fri, 26 Jan 2018 19:42:00 GMT


ASF GitHub Bot commented on LANG-1373:

Github user kinow commented on the issue:
    Ack :-) haven't had time to review it as we have a short summer around here, so have added
a note to have a look at StopWatch (which I'm not familiar with) and at this variation.
    Said that, had a very brief peek at the code from the browser without using the IDE. The
code looks great! Only small minor things I could see were a duplicated white line (which
doesn't matter tbh) and the the formatting. If I recall correctly, [lang] uses 4 spaces instead
of 2? Though I could be wrong.
    Thanks for being so patient. I intend to review it as soon as I get some spare time (IOW
once the weather gets back to our normal 10-17C cloudy days with with windy rains). But happy
if anyone beats me to it.

> Stopwatch based capability for nested, named, timings in a call stack
> ---------------------------------------------------------------------
>                 Key: LANG-1373
>                 URL:
>             Project: Commons Lang
>          Issue Type: New Feature
>          Components: lang.time.*
>            Reporter: Otto Fowler
>            Priority: Major
> While working on adding some timing functionality to a Metron feature, I came across
> Stopwatch class, but found that it didn’t suite my needs.
> What I wanted to do was to create a timing from a top level function in our Stellar dsl,
and have have a group of related timings, such that the end result was the overall time of
the call, and nested timings of other calls executed during the dsl execution of that function.
These timings would all be named, and have a path for identification and include timing the
language compiler/execution as well as the function execution itself. It would be helpful
if they were tagged in some way as well, such that the consumer could filter during visitation.
> So I have written StackWatch to provide this functionality, and submitted it in a Metron
> From the PR description:
> StackWatch
> A set of utility classes under the new package stellar.common.timing have been added.
These provide the StackWatch functionality.
> StackWatch provides an abstraction over the Apache Commons StopWatch class that allows
callers to create multiple named and possibly nested timing operations.
> <…>
> This class may be more generally useful to this and other projects, but I am not sure
where it would live since we wouldn’t want it in common.
> StackWatch uses a combination of Deque and a custom Tree implementation to create, start
and end timing operations.
> A Visitor pattern is also implemented to allow for retrieving the results after the completion
of the operation.

This message was sent by Atlassian JIRA

View raw message