commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ate Douma (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SCXML-277) setJexlEngineSilent and setJexlEngineStrict functions were removed from API
Date Sun, 21 Jan 2018 21:46:01 GMT

    [ https://issues.apache.org/jira/browse/SCXML-277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16333693#comment-16333693
] 

Ate Douma commented on SCXML-277:
---------------------------------

Jexl3 now initializes the Jexl Engine using final values for strict and silent. Dynamically
changing these no longer work, hence the setters no longer are meaningful.

I agree the current getters and flags are now confusing, although they might be useful if/when
someone wants to extend JexlEvaluator.

Furthermore, while I introduced these flags in SCXML-183 I no longer think these are useful
to retain, as the default Jexl3 configuration (strict, non-silent on expression exceptions)
are more and most practical.

For the same reasoning, the changes I recently needed to introduce with SCXML-258 to allow/keep
strict=false by default (for Jexl only) also no longer are practical, and made the API (up
to the SCXMLExecutor) more complex/ugly.

I'll create a new issue to drop these as no longer needed.


Whoever really needs to use Jexl in a non-default way like with strict=false and/or silent=true
can extend the JexlEvaluator class and override its createJexlEngine() method.

 

> setJexlEngineSilent and setJexlEngineStrict functions were removed from API
> ---------------------------------------------------------------------------
>
>                 Key: SCXML-277
>                 URL: https://issues.apache.org/jira/browse/SCXML-277
>             Project: Commons SCXML
>          Issue Type: Bug
>    Affects Versions: 2.0
>            Reporter: Shalom Crown
>            Assignee: Ate Douma
>            Priority: Major
>
> After SCXML-254, the functions _setJexlEngineSilent_ and _setJexlEngineStrict_ were removed
from the JexlEvaluator, with no apparent replacement.
> Interestingly, the underlying functionality and getters for the silent and strict flags
remain.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message