commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Keppler (JIRA)" <j...@apache.org>
Subject [jira] [Created] (TEXT-111) WordUtils.wrap must calculate offset increment from wrapOn pattern length
Date Tue, 09 Jan 2018 10:20:00 GMT
Michael Keppler created TEXT-111:
------------------------------------

             Summary: WordUtils.wrap must calculate offset increment from wrapOn pattern length
                 Key: TEXT-111
                 URL: https://issues.apache.org/jira/browse/TEXT-111
             Project: Commons Text
          Issue Type: Bug
    Affects Versions: 1.2
            Reporter: Michael Keppler


WordUtils.wrap(...) allows to specify the "wrapOn" regular expression to be used as breakable
characters. If this pattern is a zero width assertion or is longer than 1 charachter, then
the output is wrong because the wrapping algorithm always skips one character (assuming the
line break character has a width of 1).

Example failing test:

{code:java}
assertThat(WordUtils.wrap("abcdef", 2, "\n", false, "(?=d)")).isEqualTo("abc\ndef");
// produces "abc\nef" instead
{code}

Fix would be to change the 2 occurences of

{code:java}
offset = spaceToWrapAt + 1;
{code}

to

{code:java}
offset = spaceToWrapAt + matcher.end() - matcher.start();
{code}

thereby not advancing 1 character each time, but as many characters as were just matched.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message