commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gilles (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEOMETRY-3) Make Points and Vectors VALJOs
Date Fri, 06 Jul 2018 22:51:00 GMT

    [ https://issues.apache.org/jira/browse/GEOMETRY-3?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535447#comment-16535447
] 

Gilles commented on GEOMETRY-3:
-------------------------------

Hi.

Sorry for the delay, I'm away for holidays (AFK for most of the day, and with a not-so-good
connection for the rest).
I've committed a new branch "GEOMETRY-3__TBR", if it can make it easier for potential reviewers.

bq. Let me know what you think.

I'm not too keen of the interfaces names, but I might be missing the point. Does it relate
to similar names in the JDK?


> Make Points and Vectors VALJOs
> ------------------------------
>
>                 Key: GEOMETRY-3
>                 URL: https://issues.apache.org/jira/browse/GEOMETRY-3
>             Project: Apache Commons Geometry
>          Issue Type: Improvement
>            Reporter: Matt Juntunen
>            Assignee: Matt Juntunen
>            Priority: Minor
>
> Ensure that all Point and Vector classes meet the requirements for being VALJOs as described
here: [http://blog.joda.org/2014/03/valjos-value-java-objects.html]. Some of this work has
already been done as part of  GEOMETRY-2. The classes to update are:
>  * o.a.c.geometry.euclidean.oned.Point1D/Vector1D
>  * o.a.c.geometry.euclidean.twod.Point2D/Vector2D
>  * o.a.c.geometry.euclidean.threed.Point3D/Vector3D
>  * o.a.c.geometry.spherical.oned.S1Point
>  * o.a.c.geometry.spherical.twod.S2Point
> Required changes include the following:
>  * Create static factory methods for creating instances using the "of" naming convention.
>  * Make constructors private
>  * Add parse methods to return instances from "canonical" toString representation
>  * Update all uses of the class to use the factory methods instead of the constructor
>  
> Pull request: https://github.com/apache/commons-geometry/pull/4



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message