commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (COMPRESS-459) CPIO fails decoding multibyte name entries
Date Wed, 11 Jul 2018 07:23:00 GMT

    [ https://issues.apache.org/jira/browse/COMPRESS-459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16539652#comment-16539652
] 

ASF GitHub Bot commented on COMPRESS-459:
-----------------------------------------

Github user ctron commented on the issue:

    https://github.com/apache/commons-compress/pull/67
  
    Thanks @bodewig for reviewing this PR. Yes you are right, with everything :wink: 
    
    I amended the PR, fixing the issues with the original PR and added the functionality to
the output stream as well. The made them two commits for to easier understand what was fixed
and what added. It can be squashed later on if required.


> CPIO fails decoding multibyte name entries
> ------------------------------------------
>
>                 Key: COMPRESS-459
>                 URL: https://issues.apache.org/jira/browse/COMPRESS-459
>             Project: Commons Compress
>          Issue Type: Bug
>          Components: Compressors
>    Affects Versions: 1.9, 1.17
>            Reporter: Jens Reimann
>            Priority: Major
>
> Having a CPIO archive in (e.g. UTF-8) mode and having a name entry with a name containing
multi-byte characters the decoder fails.
> The problem IMHO is the "getHeaderPadCount" method, which assumes a single byte per character:
>  
> {code:java}
>     public int getHeaderPadCount(){
>         if (this.alignmentBoundary == 0) { return 0; }
>         int size = this.headerSize + 1;  // Name has terminating null
>         if (name != null) {
>             size += name.length();
>         }
>         final int remain = size % this.alignmentBoundary;
>         if (remain > 0){
>             return this.alignmentBoundary - remain;
>         }
>         return 0;
>     }
> {code}
> However this may (or may not) be true for UTF-8.
>  
> Also it wouldn't be enough to call "String#getBytes(…)" as this might already transform
the underlying bytes.
> The proper solution would be to provide the name size, as read from the CPIO stream,
and pass it to the entry.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message