commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jochen Wiedmann (JIRA)" <j...@apache.org>
Subject [jira] [Reopened] (IO-582) ObservableInputStream.Observer are package-private
Date Fri, 27 Jul 2018 12:57:00 GMT

     [ https://issues.apache.org/jira/browse/IO-582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Jochen Wiedmann reopened IO-582:
--------------------------------
      Assignee: Jochen Wiedmann

I disagree, sebb, because the MessageCalculatingInputStream is in the same package, thus can
easily use package-private methods.

 

> ObservableInputStream.Observer are package-private
> --------------------------------------------------
>
>                 Key: IO-582
>                 URL: https://issues.apache.org/jira/browse/IO-582
>             Project: Commons IO
>          Issue Type: Bug
>          Components: Streams/Writers
>    Affects Versions: 2.6
>            Reporter: Bruno Palos
>            Assignee: Jochen Wiedmann
>            Priority: Minor
>             Fix For: 2.7
>
>
> Hi,
> According with the documentation of `ObservableInputStream` and `ObservableInputStream.Observer`,
it should be possible to use those classes as part of the `commons-io` utilities. However,
`ObservableInputStream.Observer`'s methods are package private and can't be extended outside
the project's source code.
> My suggestion is to make `ObservableInputStream.Observer`'s methods protected.
> I'm happy to open a PR for this.
> Thank you
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message