commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IMAGING-154) Remove Debug class
Date Wed, 15 Aug 2018 14:28:00 GMT

    [ https://issues.apache.org/jira/browse/IMAGING-154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16581139#comment-16581139
] 

ASF GitHub Bot commented on IMAGING-154:
----------------------------------------

Github user garydgregory commented on a diff in the pull request:

    https://github.com/apache/commons-imaging/pull/35#discussion_r210286324
  
    --- Diff: src/main/java/org/apache/commons/imaging/formats/bmp/BmpImageParser.java ---
    @@ -327,7 +331,7 @@ private BmpImageContents readImageContents(final InputStream is,
             switch (bhi.compression) {
             case BI_RGB:
                 if (verbose) {
    --- End diff --
    
    Seeing "if verbose" and then "log at the info level" is slightly confusing here. If we
want to keep the 'verbose' setting then maybe the code should rename this to 'logInfo', or,
should we provide a setting that contains the log level to use when 'verbose' is enabled?


> Remove Debug class
> ------------------
>
>                 Key: IMAGING-154
>                 URL: https://issues.apache.org/jira/browse/IMAGING-154
>             Project: Commons Imaging
>          Issue Type: Task
>    Affects Versions: Patch Needed
>            Reporter: Benedikt Ritter
>            Assignee: Bruno P. Kinoshita
>            Priority: Major
>             Fix For: 1.0
>
>
> Low level libraries should not do logging, but communicate through the use of exceptions
and meaningful return values. Remove the Debug class and  all it's uses.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message