commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IMAGING-154) Remove Debug class
Date Wed, 15 Aug 2018 14:29:00 GMT

    [ https://issues.apache.org/jira/browse/IMAGING-154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16581143#comment-16581143
] 

ASF GitHub Bot commented on IMAGING-154:
----------------------------------------

Github user garydgregory commented on a diff in the pull request:

    https://github.com/apache/commons-imaging/pull/35#discussion_r210286764
  
    --- Diff: src/main/java/org/apache/commons/imaging/formats/png/chunks/PngChunkText.java
---
    @@ -42,9 +47,9 @@ public PngChunkText(final int length, final int chunkType, final int
crc, final
             final int textLength = bytes.length - (index + 1);
             text = new String(bytes, index + 1, textLength, StandardCharsets.ISO_8859_1);
     
    -        if (getDebug()) {
    -            System.out.println("Keyword: " + keyword);
    -            System.out.println("Text: " + text);
    +        if (LOGGER.isLoggable(Level.FINE)) {
    --- End diff --
    
    Uhg, the JUL level names are AWFUL :=(


> Remove Debug class
> ------------------
>
>                 Key: IMAGING-154
>                 URL: https://issues.apache.org/jira/browse/IMAGING-154
>             Project: Commons Imaging
>          Issue Type: Task
>    Affects Versions: Patch Needed
>            Reporter: Benedikt Ritter
>            Assignee: Bruno P. Kinoshita
>            Priority: Major
>             Fix For: 1.0
>
>
> Low level libraries should not do logging, but communicate through the use of exceptions
and meaningful return values. Remove the Debug class and  all it's uses.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message