commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (IMAGING-154) Remove Debug class
Date Thu, 16 Aug 2018 09:01:00 GMT


ASF GitHub Bot commented on IMAGING-154:

Github user kinow commented on a diff in the pull request:
    --- Diff: src/main/java/org/apache/commons/imaging/formats/psd/ ---
    @@ -45,9 +50,14 @@ public PsdHeaderInfo(final int version, final byte[] reserved, final
int channel
         public void dump() {
    -        final PrintWriter pw = new PrintWriter(new OutputStreamWriter(System.out, Charset.defaultCharset()));
    -        dump(pw);
    -        pw.flush();
    +        try (StringWriter sw = new StringWriter(); PrintWriter pw = new PrintWriter(sw))
    --- End diff --
    @garydgregory I'm not sure how to refactor it. If you look at the `dump` methods, you
will see they are scattered all over the place, but there's no `@Override` tags, as they are
not defined in any parent class.........
    I am ignoring this for now, as we could have users coming from Sanselan using these methods.
But for 2.x I would like to tackle this problem and either remove the `dump` methods, or have
a design with a base class defining the signature of these methods.
    That would give us a place to implement a method that could remove this duplication.
    The alternative that I see here, is to add a `Util` class to the project, and add a method
to remove the duplication. But I am not very fond of `Util` classes for a case like this one
(where a proper design would remove the need for it).
    I hope this makes sense. Do you think we could ignore this duplication for now, and fix
in the upcoming (hopefully soon) next releases?

> Remove Debug class
> ------------------
>                 Key: IMAGING-154
>                 URL:
>             Project: Commons Imaging
>          Issue Type: Task
>    Affects Versions: Patch Needed
>            Reporter: Benedikt Ritter
>            Assignee: Bruno P. Kinoshita
>            Priority: Major
>             Fix For: 1.0
> Low level libraries should not do logging, but communicate through the use of exceptions
and meaningful return values. Remove the Debug class and  all it's uses.

This message was sent by Atlassian JIRA

View raw message