commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (VALIDATOR-424) ISINCheckDigit could extend LuhnCheckDigit
Date Wed, 22 Aug 2018 01:20:00 GMT

    [ https://issues.apache.org/jira/browse/VALIDATOR-424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16588213#comment-16588213
] 

Alex commented on VALIDATOR-424:
--------------------------------

Here is a summary of the changes I will make to implement this improvement:
 # remove final from LuhnCheckDigit class declaration to allow ISINCheckDigit to be a subclass
 # update the class declaratoin in ISINCheckDigit to extend LuhnCheckDigit
 # remove 10 from constructor in ISINCheckDigit as this calls the constructor in the super
class
 # remove protected int weightedValue(int charValue, int leftPos, int rightPos) method from
ISINCheckDigit as this now is inherited from LuhnCheckDigit
 # remove position weight array from ISINCheckDigit, as this is only used in the weightedValue(int
charValue, int leftPos, int rightPos) which is now in the superclas

> ISINCheckDigit could extend LuhnCheckDigit
> ------------------------------------------
>
>                 Key: VALIDATOR-424
>                 URL: https://issues.apache.org/jira/browse/VALIDATOR-424
>             Project: Commons Validator
>          Issue Type: Improvement
>    Affects Versions: 1.6
>            Reporter: Sebb
>            Priority: Major
>
> ISINCheckDigit is a version of Luhn which allows alphabetic characters.
> The class could extend the Luhn class.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message