commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jan Martin Keil (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TEXT-104) Jaro Winkler Distance refers to similarity
Date Mon, 06 Aug 2018 11:29:00 GMT

    [ https://issues.apache.org/jira/browse/TEXT-104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16570072#comment-16570072
] 

Jan Martin Keil commented on TEXT-104:
--------------------------------------

{quote}I'm definitely open to suggestion on how to more effectively convey that the "Jaro-Winkler
Distance" is indeed not a mathematical metric.
{quote}
What about having a second interface {{SimilarityMetric extends SimilarityScore}}. Each similarity
class that is a mathematical metric implements {{SimilarityMetric}}, each other similarity
class only implements {{SimilarityScore}}. This is analogue to e.g. {{HashMap implements Map}}
but {{TreeMap implements NavigableMap}}. This allows to use type safety to enforce the use
of similarities that are a mathematical metric where needed.

> Jaro Winkler Distance refers to similarity
> ------------------------------------------
>
>                 Key: TEXT-104
>                 URL: https://issues.apache.org/jira/browse/TEXT-104
>             Project: Commons Text
>          Issue Type: Improvement
>    Affects Versions: 1.1
>            Reporter: Nikos Karagiannakis
>            Priority: Trivial
>             Fix For: 2.0
>
>
> The 'apply' method returns the similarity score instead of the distance score as implied
from the class name. 
> It is stated in the javadoc, but it is not aligned with the approach of the rest similarity
scores in the same package (e.g LevenshteinDetailedDistance). 
> Maybe a rename of the class or the method to avoid confusion?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message