commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <>
Subject [jira] [Commented] (VALIDATOR-447) ISBN style numbers outside ISBN range returning true for isValid
Date Tue, 28 Aug 2018 11:53:00 GMT


Sebb commented on VALIDATOR-447:

AFAICT, it's impossible in general to fully validate an ISBN - even with the XML file, there
will be numbers that don't (yet) correspond with actual publications.

Also, the XML file changes frequently (e.g. the attached version (Aug 23) is already out of
date - there is one dated Aug 28).

Further, it looks as though the HTTP server does not support ETAG or Modified timestamps either,
so AFAICT one would have to download the full XML file on a regular basis.

The code currently detects generic errors such as unexpected prefix and bad checksum.
(And AFAIK it does not reject any valid codes - that would obviously be a bug).

What is the use case for stricter validation?
Is there sufficient demand for this to be implemented, documented and maintained?

> ISBN style numbers outside ISBN range returning true for isValid
> ----------------------------------------------------------------
>                 Key: VALIDATOR-447
>                 URL:
>             Project: Commons Validator
>          Issue Type: Improvement
>          Components: Routines
>            Reporter: Alex
>            Priority: Major
>              Labels: validators
>         Attachments: RangeMessage.xml
> All 13 digit EANs with the 979 prefix are validating as ISBNs (ISBNValidator). There
are 2 issues with this.
>  # 979-0 prefixed numbers are allocated to the ISMN agency and represent music works.
>  # 979-[2-9] are unassigned at present, that is they have not yet been allocated to a
country agency (or another authority).
> see attached xml (from [|]
[^RangeMessage.xml] ) for the current valid ranges for ISBN 
> and []
> An example unassigned 'ISBN' is 9792222222223

This message was sent by Atlassian JIRA

View raw message