commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (VALIDATOR-447) ISBN style numbers outside ISBN range returning true for isValid
Date Tue, 28 Aug 2018 14:36:00 GMT

    [ https://issues.apache.org/jira/browse/VALIDATOR-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16595057#comment-16595057
] 

Alex commented on VALIDATOR-447:
--------------------------------

thanks again for the feedback. I think I broadly agree. I am not suggesting that we should
try and validate against actual publications and actual allocated ISBNs. Validating ISBNs
that are not in a range that is allocted to ISBNs is more the issue generally. This could
probably be disclaimed in the javadocs (what is being validated is ean13s with 978 and 979
prefixes).

On the ISMN issue, which is probably more misleading (eg 979-0-2600-0043-8), a lightweight
solution would be to add a isISMN method that applies additional validation to confirm if
the item is an ISMN (rather than an ISBN)

> ISBN style numbers outside ISBN range returning true for isValid
> ----------------------------------------------------------------
>
>                 Key: VALIDATOR-447
>                 URL: https://issues.apache.org/jira/browse/VALIDATOR-447
>             Project: Commons Validator
>          Issue Type: Improvement
>          Components: Routines
>            Reporter: Alex
>            Priority: Major
>              Labels: validators
>         Attachments: RangeMessage.xml
>
>
> All 13 digit EANs with the 979 prefix are validating as ISBNs (ISBNValidator). There
are 2 issues with this.
>  # 979-0 prefixed numbers are allocated to the ISMN agency and represent music works.
[https://www.ismn-international.org/whatis.html]
>  # 979-[2-9] are unassigned at present, that is they have not yet been allocated to a
country agency (or another authority).
> see attached xml (from [www.isbn-international.org/export_rangemessage.xml|http://www.isbn-international.org/export_rangemessage.xml]
[^RangeMessage.xml] ) for the current valid ranges for ISBN 
> and [https://en.wikipedia.org/wiki/List_of_ISBN_identifier_groups#Identifiers_of_the_979-_prefix]
> An example unassigned 'ISBN' is 9792222222223



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message