commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LANG-1417) Deprecate ThreadPredicate and ThreadGroupPredicate in favor of java.util.function.Predicate
Date Tue, 28 Aug 2018 08:25:00 GMT

    [ https://issues.apache.org/jira/browse/LANG-1417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16594692#comment-16594692
] 

ASF GitHub Bot commented on LANG-1417:
--------------------------------------

GitHub user britter opened a pull request:

    https://github.com/apache/commons-lang/pull/349

    LANG-1417: Deprecate ThreadPredicate and ThreadGroupPredicate in favo…

    …r of java.util.function.Predicate
    
    I don't see a way to let ThreadGroupPredicate and ThreadPredicate inherit from java.util.function.Predicate.
See my comment in [LANG-1417](https://issues.apache.org/jira/browse/LANG-1417). @salyh as
author of the initial implementation, can you have a look please? Am I missing something?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/britter/commons-lang LANG-1417

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-lang/pull/349.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #349
    
----
commit a5a3b374b1f1ef0c7b7746e58a0dde19303e4492
Author: Benedikt Ritter <britter@...>
Date:   2018-08-28T08:22:40Z

    LANG-1417: Deprecate ThreadPredicate and ThreadGroupPredicate in favor of java.util.function.Predicate

----


> Deprecate ThreadPredicate and ThreadGroupPredicate in favor of java.util.function.Predicate
> -------------------------------------------------------------------------------------------
>
>                 Key: LANG-1417
>                 URL: https://issues.apache.org/jira/browse/LANG-1417
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: lang.*
>            Reporter: Benedikt Ritter
>            Priority: Major
>             Fix For: 3.9
>
>
> Since we upgraded the Java language requirement to Java 8, we can deprecate our custom
ThreadPredicate and ThreadGroupPredicate implementations.
> It looks like our initial plan to let ThreadPredicate and ThreadGroupPredicate extend
java.util.function.Predicate is not possible. This is because auf AlwaysTruePredicate and
NamePredicate extending both interfaces. This leads to the situation that these classes would
inherit from both Predicate<Thread> and Predicate<ThreadGroup>, which is not possible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message