commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bruno P. Kinoshita (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (TEXT-111) WordUtils.wrap must calculate offset increment from wrapOn pattern length
Date Sun, 03 Mar 2019 11:12:00 GMT

     [ https://issues.apache.org/jira/browse/TEXT-111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Bruno P. Kinoshita resolved TEXT-111.
-------------------------------------
       Resolution: Fixed
         Assignee: Bruno P. Kinoshita
    Fix Version/s: 1.7

> WordUtils.wrap must calculate offset increment from wrapOn pattern length
> -------------------------------------------------------------------------
>
>                 Key: TEXT-111
>                 URL: https://issues.apache.org/jira/browse/TEXT-111
>             Project: Commons Text
>          Issue Type: Bug
>    Affects Versions: 1.2
>            Reporter: Michael Keppler
>            Assignee: Bruno P. Kinoshita
>            Priority: Major
>             Fix For: 1.7
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> WordUtils.wrap(...) allows to specify the "wrapOn" regular expression to be used as breakable
characters. If this pattern is a zero width assertion or is longer than 1 charachter, then
the output is wrong because the wrapping algorithm always skips one character (assuming the
line break character has a width of 1).
> Example failing test:
> {code:java}
> assertThat(WordUtils.wrap("abcdef", 2, "\n", false, "(?=d)")).isEqualTo("abc\ndef");
> // produces "abc\nef" instead
> {code}
> Fix would be to change the 2 occurences of
> {code:java}
> offset = spaceToWrapAt + 1;
> {code}
> to
> {code:java}
> offset = spaceToWrapAt + matcher.end() - matcher.start();
> {code}
> thereby not advancing 1 character each time, but as many characters as were just matched.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message