commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (TEXT-126) Dice's Coefficient Algorithm in String similarity
Date Sun, 24 Mar 2019 14:27:00 GMT

     [ https://issues.apache.org/jira/browse/TEXT-126?focusedWorklogId=217713&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-217713
]

ASF GitHub Bot logged work on TEXT-126:
---------------------------------------

                Author: ASF GitHub Bot
            Created on: 24/Mar/19 14:26
            Start Date: 24/Mar/19 14:26
    Worklog Time Spent: 10m 
      Work Description: aherbert commented on pull request #103: TEXT-126: Adding Sorensen-Dice
similarity algoritham
URL: https://github.com/apache/commons-text/pull/103#discussion_r268436249
 
 

 ##########
 File path: src/test/java/org/apache/commons/text/similarity/SorensenDiceSimilarityTest.java
 ##########
 @@ -0,0 +1,94 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.commons.text.similarity;
+
+import static org.assertj.core.api.Assertions.assertThatIllegalArgumentException;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+
+import org.junit.jupiter.api.BeforeAll;
+import org.junit.jupiter.api.Test;
+
+/**
+ * Unit tests for {@link SorensenDicesSimilarity}.
+ */
+public class SorensenDiceSimilarityTest {
+
+    private static SorensenDiceSimilarity similarity;
+
+    @BeforeAll
+    public static void setUp() {
+        similarity = new SorensenDiceSimilarity();
+    }
+
+    @Test
+    public void test() {
+        assertEquals(0.25d, similarity.apply("night", "nacht"));
+    }
+
+    @Test
+    public void testGetSorensenDicesSimilarity_StringString() {
+
+        assertEquals(1d, similarity.apply("", ""));
+        assertEquals(0d, similarity.apply("", "a"));
+        assertEquals(0d, similarity.apply("a", ""));
+        assertEquals(1d, similarity.apply("a", "a"));
+        assertEquals(0d, similarity.apply("a", "b"));
+        assertEquals(1.0d, similarity.apply("foo", "foo"));
+        assertEquals(0.8d, similarity.apply("foo", "foo "));
+        assertEquals(0.4d, similarity.apply("frog", "fog"));
+        assertEquals(0.0d, similarity.apply("fly", "ant"));
+        assertEquals(0.0d, similarity.apply("elephant", "hippo"));
+        assertEquals(0.0d, similarity.apply("hippo", "elephant"));
+        assertEquals(0.0d, similarity.apply("hippo", "zzzzzzzz"));
+        assertEquals(0.5d, similarity.apply("hello", "hallo"));
+        assertEquals(0.7d, round(similarity.apply("ABC Corporation", "ABC Corp"), 1));
+        assertEquals(0.7d, round(similarity.apply("D N H Enterprises Inc", "D &amp; H
Enterprises, Inc."), 1));
+        assertEquals(0.8d,
+                round(similarity.apply("My Gym Children's Fitness Center", "My Gym. Childrens
Fitness"), 1));
+        assertEquals(0.7d, round(similarity.apply("PENNSYLVANIA", "PENNCISYLVNIA"), 1));
+        assertEquals(0.9d, round(similarity.apply("/opt/software1", "/opt/software2"), 1));
+        assertEquals(0.6d, round(similarity.apply("aaabcd", "aaacdb"), 1));
+        assertEquals(0.6d, round(similarity.apply("John Horn", "John Hopkins"), 1));
+
+    }
+
+    @Test
+    public void testGetSorensenDicesSimilarity_NullNull() {
+        assertThatIllegalArgumentException().isThrownBy(() -> {
+            similarity.apply(null, null);
+        });
+    }
+
+    @Test
+    public void testGetSorensenDicesSimilarity_StringNull() {
+        assertThatIllegalArgumentException().isThrownBy(() -> {
+            similarity.apply(" ", null);
+        });
+    }
+
+    @Test
+    public void testGetSorensenDicesSimilarity_NullString() {
+        assertThatIllegalArgumentException().isThrownBy(() -> {
+            similarity.apply(null, "clear");
+        });
+    }
+
+    public static double round(double value, int precision) {
 
 Review comment:
   No need to be public. Why are you rounding anyway? A test like this can be very precise.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 217713)
    Time Spent: 14h 20m  (was: 14h 10m)

> Dice's Coefficient Algorithm in String similarity
> -------------------------------------------------
>
>                 Key: TEXT-126
>                 URL: https://issues.apache.org/jira/browse/TEXT-126
>             Project: Commons Text
>          Issue Type: Improvement
>            Reporter: Vicky Chawda
>            Priority: Major
>          Time Spent: 14h 20m
>  Remaining Estimate: 0h
>
> I'd like to propose an extension to the algorithms for string similarity in *commons-text/src/main/java/org/apache/commons/text/similarity/*
>  Dice's Coefficient Algorithm can be helpful for many who are looking for ranking similarities
in strings.
> *Inspired from* - [http://www.catalysoft.com/articles/StrikeAMatch.html]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message