commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [commons-io] garydgregory commented on issue #97: IO-628: Migration to JUnit Jupiter
Date Wed, 02 Oct 2019 18:15:27 GMT
garydgregory commented on issue #97: IO-628: Migration to JUnit Jupiter
URL: https://github.com/apache/commons-io/pull/97#issuecomment-537616185
 
 
   > > > > Hi @mureinik,
   > > > > Thank you for your update.
   > > > > It seems like in `TailerTest` there should be a cleaner way to tear
down tests than by calling `Thead.interrupt()`. Can `org.apache.commons.io.input.Tailer.stop()`
be used with or without changes to `Tailer` to clean up tests in a nicer manner?
   > > > > Gary
   > > > 
   > > > 
   > > > @garydgregory The original JUnit 4 test tried doing that in the `tearDown()`
method, which is too late (since it's called after the temp dir deletion is attempted). Note
this isn't new to JUnit Jupiter - it was too late in JUnit 4 too, but it was pretty harmless
there (the deletion silently failed, and just left some junk on the temp filesystem, whereas
in Jupiter it fails the test).
   > > > By using a shared temp directory, we can delay the deletion till after the
end of the entire class, and won't have to try something dirty like explicitly interrupting
the thread, which would be arguably cleaner. I've updated the PR with this approach..
   > > 
   > > 
   > > @mureinik
   > > I still see calls to `thread.interrupt();`; did you forget to remove those?
   > 
   > @garydgregory The original JUnit 4 test has some calls to `thread.interupt()` - in
`testTailer()` and `testInterrupt()` which I didn't touch (as they are part fo the test logic,
not the migration to Jupiter). The diff (https://github.com/apache/commons-io/pull/97/files#diff-8f25c6c9a344f344c3266085f09adeb5)
doesn't contain any new calls to `interrupt`, unless I'm missing something really obvious.
Can you elaborate which calls you're referring to?
   
   @mureinik ,
   Ah, I incorrectly assumed that your change would remove all calls to `thread.interupt()`
- in `testTailer()`. If they were already there, it fair to leave them as is for now. I will
complete the review tonight.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message