commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [commons-lang] kinow commented on a change in pull request #308: LANG-1366 : Add Feature for No ClassName and MultiLine StringStyle
Date Sat, 05 Oct 2019 05:49:24 GMT
kinow commented on a change in pull request #308: LANG-1366 : Add Feature for No ClassName
and MultiLine StringStyle
URL: https://github.com/apache/commons-lang/pull/308#discussion_r331734101
 
 

 ##########
 File path: src/test/java/org/apache/commons/lang3/builder/NoClassNameMultiLineToStringStyleTest.java
 ##########
 @@ -0,0 +1,127 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.commons.lang3.builder;
+
+import org.apache.commons.lang3.StringUtils;
+import org.apache.commons.lang3.builder.ToStringStyleTest.Person;
+import org.junit.jupiter.api.AfterEach;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+
+
+import java.util.ArrayList;
+import java.util.HashMap;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+
+/**
+ * Unit tests {@link org.apache.commons.lang3.builder.NoClassNameMultiLineToStringStyleTest}.
+ */
+public class NoClassNameMultiLineToStringStyleTest {
 
 Review comment:
   Yeah, and if it's not something that can be checked with checkstyle or with the other build
tools, we have no clear way to enforce... and having to ask users to alter their PR's can
be a bit frustrating for the contributors.
   
   For this reason I think it might be easier to just keep things as they are, and accept
new submissions using either public, private, or package-protected.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message