commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [commons-lang] garydgregory commented on issue #308: LANG-1366 : Add Feature for No ClassName and MultiLine StringStyle
Date Sat, 05 Oct 2019 12:43:27 GMT
garydgregory commented on issue #308: LANG-1366 : Add Feature for No ClassName and MultiLine
StringStyle
URL: https://github.com/apache/commons-lang/pull/308#issuecomment-538646626
 
 
   TBH (and sorry for coming in a bit late), I am against a PR like this one. 
   
   My concern here is that there is a huge number of configuration combinations possible for
`ToStringStyle`. As I am sure we do not plan on adding all possible options, adding this one
just feels like fulfilling some narrow use case while Commons Lang is a general purpose library.

   
   I'd hope not to see this class grow and grow and grow overtime; but, if this changes comes
in, it becomes harder to say no to other niche configuration combinations.
   
   This specific PR is so, well, specific, that while I am sure the author feels it is general
purpose enough for inclusion here, I would claim it is not and that it belongs in their application,
not Commons Lang.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message