commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [commons-lang] verhas commented on issue #461: Lang 1491
Date Sat, 05 Oct 2019 17:19:36 GMT
verhas commented on issue #461: Lang 1491
URL: https://github.com/apache/commons-lang/pull/461#issuecomment-538670127
 
 
   Why doesn't the project has a unique and generally followed style-guide that governs questions
like this.
   
   You say that "if future PR's have tests that omit or use `private` modifier, I'm all good
for that. Just don't think we need to change every test we have had."
   
   My other pull request was refused because I omitted the `public` keyword from the `@Test`
method. I was told that this was not consistent.
   
   So you (plural), core team members are not on the same page. Whenever I create a pull request
should I bend the style to fit the needs of the specific reviewer?
   
   I made this pull request to make it consistent and also to eliminate the `public` keywords,
which in my view are essentially noise in this case.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message