commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [commons-lang] verhas edited a comment on issue #461: Lang 1491
Date Sun, 06 Oct 2019 10:05:40 GMT
verhas edited a comment on issue #461: Lang 1491
URL: https://github.com/apache/commons-lang/pull/461#issuecomment-538730441
 
 
   >So I think it doesn't require us to remove them (i.e. everything will keep working),
   
   Somehow I have the strange feeling that you did not get the notion of the whole pull request.

   
   It is not a new feature. This is not a bug fix.
   
   ## This is code cleanup.
   
   Code cleanup means to delete/modify outdated or originally wrong structures in the code
so that the code becomes more readable and thus more maintainable. By the nature of code cleanup
(also called refactoring), the functionality does not change, without it, everything will
keep working.
   
   Do you really suggest that the project does not ever need any code cleanup? All your reasonings
can be used against any code cleanup. Or, perhaps, you have some specific reason against this
actual clean-up that you have not put forth so far?
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message