commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [commons-lang] verhas edited a comment on issue #461: Lang 1491
Date Mon, 07 Oct 2019 19:37:01 GMT
verhas edited a comment on issue #461: Lang 1491
URL: https://github.com/apache/commons-lang/pull/461#issuecomment-538752300
 
 
   My change makes the code more compliant with Item 15 of Joshua Bloch Effective Java, Third
Edition (Minimize the accessibility of classes and members).
   
   Please focus on the code and do not speak about rhetoric and who is giving lectures to
whom.
   
   N.B.: You are absolutely right when you feel some emotion from my words. I really feel
pissed off when I invested a lot of effort to improve the code and what I get back is refusal
with reasons that are against documented industry best practice.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message