commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [commons-lang] garydgregory commented on issue #461: Lang 1491
Date Tue, 08 Oct 2019 20:32:23 GMT
garydgregory commented on issue #461: Lang 1491
URL: https://github.com/apache/commons-lang/pull/461#issuecomment-539691644
 
 
   Hi Peter,
   
   Thank you sharing your insights with us.
   
   The best path for the PR IMO is to minimize the change set by keeping
   elements that are public unchanged.
   
   We have had other PRs in other Commons components recently with updates
   from JUnit 4 to 5, all of these were merged and did not change visibility
   down from public.
   
   Gary
   
   On Mon, Oct 7, 2019, 16:27 Peter Verhas <notifications@github.com> wrote:
   
   > I am sorry.
   >
   > I had a discussion with my son, and he read this thread and gave me
   > feedback, that I accepted. I also edited my past comments to remove the
   > parts that I see now, were offending. I did that as a gesture and not to
   > hide the traces of my bad communication. The original versions are there,
   > visible and also included as a quote in replies word by word, which is OK.
   >
   > My son told me that the original misunderstanding was that I communicated
   > the aim of the change ambiguous. Because of that ambiguity, Mr. Kinoshita
   > was asking me about the reference where JUnit requires that the tests are
   > not public. There is no such thing. JUnit allows the tests to be public.
   > They just do not demand the tests to be public anymore as we change from
   > JUnit 4 to JUnit 5. This misunderstanding is my fault. I can also see that
   > my response to this was not-professional in the details I deleted.
   >
   > Having all said I still believe that this pull request and also the next
   > one following this is valuable for the project helping to keep the code
   > clean and up to date and the PR should not be neglected.
   >
   > —
   > You are receiving this because you commented.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/commons-lang/pull/461?email_source=notifications&email_token=AAJB6N6QZUDFFXWRYZCVD5TQNOLTRA5CNFSM4I3B2C62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEARWEGY#issuecomment-539189787>,
   > or mute the thread
   > <https://github.com/notifications/unsubscribe-auth/AAJB6N377KGZCMKXTMLNQF3QNOLTRANCNFSM4I3B2C6Q>
   > .
   >
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message