commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [commons-lang] verhas commented on a change in pull request #470: Boolean utils limited cleanup
Date Wed, 16 Oct 2019 13:49:29 GMT
verhas commented on a change in pull request #470: Boolean utils limited cleanup
URL: https://github.com/apache/commons-lang/pull/470#discussion_r335486387
 
 

 ##########
 File path: src/main/java/org/apache/commons/lang3/ArrayUtils.java
 ##########
 @@ -4803,7 +4803,7 @@ public static Object toPrimitive(final Object array) {
         }
         final boolean[] result = new boolean[array.length];
         for (int i = 0; i < array.length; i++) {
-            result[i] = array[i].booleanValue();
+            result[i] = array[i];
 
 Review comment:
   This is included here because it is directly invoked from `BooleanUtils`. There are other
similar redundant unboxings in this class in addition to this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message