commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [commons-validator] mikkomaunu edited a comment on issue #19: [VALIDATOR-455] added IBAN validator for Vatican, added also one entry for each missing IBAN type to IBANCheckDigitTest
Date Sun, 20 Oct 2019 08:46:32 GMT
mikkomaunu edited a comment on issue #19: [VALIDATOR-455] added IBAN validator for Vatican,
added also one entry for each missing IBAN type to IBANCheckDigitTest
URL: https://github.com/apache/commons-validator/pull/19#issuecomment-544231291
 
 
   Errors reported by Travis look unrelated me. For JDK 11 there seems to differences in Date
parsing. JDK 13 build fails because source and target should be at least 1.7.
   
   One of Date parsing/formatting issues is due AbstractFormatValidator, which instead of
creating SimpleDateFormat with constructor that takes Locale as argument, builds DateFormatSymbols
and passes that to constructor:
    `    protected Format getFormat(String pattern, Locale locale) {
           DateFormat formatter = null;
           boolean usePattern = (pattern != null && pattern.length() > 0);
           if (!usePattern) {
               formatter = (DateFormat)getFormat(locale);
           } else if (locale == null) {
               formatter = new SimpleDateFormat(pattern);
           } else {
               DateFormatSymbols symbols = new DateFormatSymbols(locale);
               formatter = new SimpleDateFormat(pattern, symbols);
           }
           formatter.setLenient(false);
           return formatter;
       }`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message