commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [commons-beanutils] garydgregory commented on a change in pull request #8: Convert Collections4 to java.util.function
Date Sun, 20 Oct 2019 21:32:12 GMT
garydgregory commented on a change in pull request #8: Convert Collections4 to java.util.function
URL: https://github.com/apache/commons-beanutils/pull/8#discussion_r336798711
 
 

 ##########
 File path: src/main/java/org/apache/commons/beanutils2/BeanPredicate.java
 ##########
 @@ -50,6 +50,18 @@ public BeanPredicate(final String propertyName, final Predicate predicate)
{
         this.propertyName = propertyName;
         this.predicate = predicate;
     }
+    
+    /**
+     * Evaluates the given object by applying the {@link #getPredicate()}
+     * to a property value named by {@link #getPropertyName()}.
+     *
+     * @param object The object being evaluated
+     * @return the result of the predicate evaluation
+     * @throws IllegalArgumentException when the property cannot be evaluated
+     */
+    public boolean evaluate(Object object) {
 
 Review comment:
   No need to deprecated, we can just remove it since we are in a major release.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message