commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [commons-compress] garydgregory commented on a change in pull request #82: Made some variable names more consistent with the other parts.
Date Mon, 21 Oct 2019 12:57:51 GMT
garydgregory commented on a change in pull request #82: Made some variable names more consistent
with the other parts.
URL: https://github.com/apache/commons-compress/pull/82#discussion_r337001230
 
 

 ##########
 File path: src/main/java/org/apache/commons/compress/archivers/zip/BitStream.java
 ##########
 @@ -48,14 +48,14 @@ int nextBit() throws IOException {
     /**
      * Returns the integer value formed by the n next bits (up to 8 bits).
      *
-     * @param n the number of bits read (up to 8)
-     * @return The value formed by the n bits, or -1 if the end of the stream has been reached
+     * @param count the number of bits read (up to 8)
+     * @return The value formed by the count bits, or -1 if the end of the stream has been
reached
      */
-    long nextBits(final int n) throws IOException {
-        if (n < 0 || n > 8) {
-            throw new IOException("Trying to read " + n + " bits, at most 8 are allowed");
+    long nextBits(final int count) throws IOException {
 
 Review comment:
   +1
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message