commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [commons-bcel] euske commented on a change in pull request #36: Made some variable names more consistent with the other parts.
Date Mon, 21 Oct 2019 15:03:12 GMT
euske commented on a change in pull request #36: Made some variable names more consistent with
the other parts.
URL: https://github.com/apache/commons-bcel/pull/36#discussion_r337070143
 
 

 ##########
 File path: src/main/java/org/apache/bcel/verifier/structurals/Subroutines.java
 ##########
 @@ -121,16 +121,16 @@ public String toString() {
             ret.append("', Instructions: '").append(instructions).append("'.");
 
             ret.append(" Accessed local variable slots: '");
-            int[] alv = getAccessedLocalsIndices();
-            for (final int element : alv) {
-                ret.append(element);ret.append(" ");
+            int[] lvs = getAccessedLocalsIndices();
+            for (final int lv : lvs) {
 
 Review comment:
   The rationale is that "lvs" (apparently LocalVariables) is consistently used in several
modules in verifier/structurals. "alv" was an outlier here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message