commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [commons-collections] garydgregory commented on a change in pull request #91: Add drain method to CollectionUtils
Date Sat, 26 Oct 2019 02:37:16 GMT
garydgregory commented on a change in pull request #91: Add drain method to CollectionUtils
URL: https://github.com/apache/commons-collections/pull/91#discussion_r339282833
 
 

 ##########
 File path: src/main/java/org/apache/commons/collections4/CollectionUtils.java
 ##########
 @@ -1791,6 +1791,63 @@ public static int maxSize(final Collection<? extends Object>
coll) {
         return list;
     }
 
+    /**
+     * Removes elements whose index are between startIndex and endIndex in the collection
and returns them.
+     * This method would have the side-effect of modifying the input collections.
+     *
+     * @param <E>  the type of object the {@link Collection} contains
+     * @param input  the collection will be operated,can't be null
+     * @param startIndex  the start index to remove element,can't be less than 0
+     * @param endIndex  the end index to remove,can't be less than startIndex
+     * @return collection of elements that removed from the input collection
+     */
+    public static <E> Collection<E> removeRange(Collection<E> input, int
startIndex, int endIndex) {
+        if (endIndex < startIndex) {
+            throw new IllegalArgumentException("The start index can't less than the end index.");
+        }
+        return CollectionUtils.removeCount(input, startIndex, endIndex-startIndex);
+    }
+
+    /**
+     * Removes the specified number of elements from the start index in the collection and
returns them.
+     * This method would have the side-effect of modifying the input collections.
 
 Review comment:
   Replace:
   This method would have the side-effect of modifying the input collections.
   
   With:
   This method modifies the input collection.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message