commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [commons-email] michael-o commented on a change in pull request #11: Throw more specific exceptions in MimeMessageParser
Date Sat, 26 Oct 2019 17:29:56 GMT
michael-o commented on a change in pull request #11: Throw more specific exceptions in MimeMessageParser
URL: https://github.com/apache/commons-email/pull/11#discussion_r339308558
 
 

 ##########
 File path: src/main/java/org/apache/commons/mail/util/MimeMessageParser.java
 ##########
 @@ -262,7 +262,7 @@ private boolean isMimeType(final MimePart part, final String mimeType)
      * @param part   the current part to be processed
      * @return the DataSource
      * @throws MessagingException creating the DataSource failed
-     * @throws IOException        creating the DataSource failed
+     * @throws IOException        error getting InputStream or unsupported encoding
 
 Review comment:
   If you throw specific IOExceptions like UnsupportedEncodingException, document it too.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message