commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [commons-compress] bodewig commented on issue #82: Made some variable names more consistent with the other parts.
Date Sun, 27 Oct 2019 15:28:05 GMT
bodewig commented on issue #82: Made some variable names more consistent with the other parts.
URL: https://github.com/apache/commons-compress/pull/82#issuecomment-546704982
 
 
   I am on the fence with this PR.
   
   Personally I don't see any benefit in consistent naming of local variables as long as the
local variables have names that can be understood. To me a local variable named `length` is
in no way clearer than one called `len`.
   
   We will never get a consistency at the level your tool is striving for on a project that
relies on numerous volunteer contributors. I don't see myself frustrating contributors by
asking them to rename their local variables on patches.
   
   @garydgregory if you see value in this and want to merge the PR after the changes you've
requested have been made I won't stand in the way but I'll otherwise ignore it myself.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message