commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [commons-imaging] kinow commented on a change in pull request #9: Imaging-163
Date Mon, 28 Oct 2019 09:27:04 GMT
kinow commented on a change in pull request #9: Imaging-163
URL: https://github.com/apache/commons-imaging/pull/9#discussion_r339462304
 
 

 ##########
 File path: src/main/java/org/apache/commons/imaging/ImageParser.java
 ##########
 @@ -682,8 +688,10 @@ public abstract Dimension getImageSize(ByteSource byteSource, Map<String,
Object
      *                            parser implementation.
      * @throws IOException        In the event of unsuccessful read or access operation.
      */
-    public abstract String getXmpXml(ByteSource byteSource, Map<String, Object> params)
-            throws ImageReadException, IOException;
+    public String getXmpXml(final ByteSource byteSource, final Map<String, Object>
params)
 
 Review comment:
   Reading the issue, and this last comment, I agree about the issue being actually a bad
design. IMO, we should move that method to an interface, perhaps `XmpEmbeddable` or some thing
that defines that it supports XMP metadata. Then implementations can choose to implement it
when appropriate.
   
   So for `PcxImageParser` it would simply not implement it. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message