commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [commons-imaging] kinow commented on issue #55: Add support to read multiple images from GIF
Date Wed, 30 Oct 2019 22:14:25 GMT
kinow commented on issue #55: Add support to read multiple images from GIF
URL: https://github.com/apache/commons-imaging/pull/55#issuecomment-548135500
 
 
   >I did not yet create a jira account but will do so for any future pull requests
   
   We can create it later too, so no problem.
   
   >I quickly dug into code as I got frustrated with an old bug in ImageIO. I hope you'll
accept my PR or let me know what to change to meet the code standard.
   
   My only concern is if this is not too specific to the GIF format. But will need to read
the proposed change in the code later with more calm.
   
   The code looks good, with comments and some tests. That's helpful for reviewers, thanks!!!
Feel free to ping me if I take too long to look into this again 👍 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message