commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [commons-collections] garydgregory commented on a change in pull request #91: Add drain method to CollectionUtils
Date Thu, 31 Oct 2019 13:55:39 GMT
garydgregory commented on a change in pull request #91: Add drain method to CollectionUtils
URL: https://github.com/apache/commons-collections/pull/91#discussion_r341148939
 
 

 ##########
 File path: src/main/java/org/apache/commons/collections4/CollectionUtils.java
 ##########
 @@ -1825,13 +1832,13 @@ public static int maxSize(final Collection<? extends Object>
coll) {
             throw new IllegalArgumentException("The collection can't be null.");
         }
         if (startIndex < 0) {
-            throw new IllegalArgumentException("The start index can't less than 0.");
+            throw new IndexOutOfBoundsException("The start index can't less than 0.");
 
 Review comment:
   You are missing words in these exception messages:
   "The start index can't less than 0."
   ->
   "The start index can't **be** less than 0."

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message